Mistuke · GitHub

@Mistuke

Copy link Copy Markdown

Contributor

Hi,

terminateJob is being called from within terminateProcess which already has a lock on the MVar.
This add a new function terminateJobUnsafe which does not take an MVar and so is not thread-safe but can be called from terminateProcess safely.

Fixes #196

Closed

@snoyberg

Copy link Copy Markdown

Collaborator

The AppVeyor tests failed on this build.

Side note: I think I'll move CI over to Github Actions instead of the Travis/AppVeyor split, just an FYI.

@Mistuke

Copy link Copy Markdown

Contributor Author

@Mistuke

@Mistuke

Copy link Copy Markdown

Contributor Author

@snoyberg alright, the test is fixed to work properly on Windows now.

snoyberg

Copy link Copy Markdown

Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. One more request: could you add a changelog entry explaining the change?

@Mistuke

@Mistuke

Copy link Copy Markdown

Contributor Author

Done.

snoyberg

@snoyberg

@snoyberg

Copy link Copy Markdown

Collaborator

Thanks!

Read the original on github.com ↗