Mistuke · GitHub

Conversation

@Mistuke

Copy link Copy Markdown

Contributor

This adds support for the new Asynchronous I/O manager in GHC for Windows[1] to process.

This is required because process uses internal GHC APIs.

Do not merge yet, however goal for this is for GHC 8.12. It is ready for review.

[1] https://gitlab.haskell.org/ghc/ghc/-/merge_requests/1224

@Mistuke

Copy link Copy Markdown

Contributor Author

/cc @bgamari (I don't know AndreasK github handle).

Mistuke

Mistuke

Mistuke

Mistuke

Mistuke

Mistuke

AndreasPK

Copy link Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will take a closer look soon.

@Mistuke

Closed

Merged

@Mistuke

Copy link Copy Markdown

Contributor Author

Arg... looks like createPipe and createPipeFd are exposed. So will have to change those too. createPipeFd will just error out. I wonder though... what's the use case of createPipeFd?

@Mistuke

@Mistuke

@Mistuke

Copy link Copy Markdown

Contributor Author

Looks like I have to drop the test using the new manager explicitly.
But this needs a small fix for older GHCs and should be done.

I will push changes for createPipe in a different pr. Any comments here @AndreasPK @snoyberg ?

bgamari

Copy link Copy Markdown

Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good to me

Open

@Mistuke

@Mistuke Mistuke changed the title WIP: Add support for WINIO to process. Add support for WinIO to process.

Jun 25, 2020

@Mistuke

@Mistuke

@Mistuke

Copy link Copy Markdown

Contributor Author

This should be the final commit. Everything passes with it.

@snoyberg

Copy link Copy Markdown

Collaborator

I'm definitely out of my depth on this one. I'm OK moving ahead with merging this if both @Mistuke and @bgamari think this is ready.

@Mistuke

Copy link Copy Markdown

Contributor Author

bgamari

Copy link Copy Markdown

Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. Thanks @Mistuke!

bgamari

@bgamari

Labels

None yet

Read the original on github.com ↗