Conversation
Contributor
This adds support for the new Asynchronous I/O manager in GHC for Windows[1] to process.
This is required because process uses internal GHC APIs.
Do not merge yet, however goal for this is for GHC 8.12. It is ready for review.
[1] https://gitlab.haskell.org/ghc/ghc/-/merge_requests/1224
Contributor Author
/cc @bgamari (I don't know AndreasK github handle).
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will take a closer look soon.
Contributor Author
Arg... looks like createPipe and createPipeFd are exposed. So will have to change those too. createPipeFd will just error out. I wonder though... what's the use case of createPipeFd?
Contributor Author
Looks like I have to drop the test using the new manager explicitly.
But this needs a small fix for older GHCs and should be done.
I will push changes for createPipe in a different pr. Any comments here @AndreasPK @snoyberg ?
Contributor
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks pretty good to me
Open
Mistuke
changed the title
WIP: Add support for WINIO to process.
Add support for WinIO to process.
Contributor Author
This should be the final commit. Everything passes with it.
Contributor
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me. Thanks @Mistuke!
Labels
None yet