Copy link
Copy Markdown
Collaborator
A minor PR with some more modularization/simplification:
- Removed duplicated code
- Removed unused arguments
type_*()data preparation function are now stored in a dictionary with switch-style selection.
Copy link
Copy Markdown
Owner
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice, thanks. One minor comment and then happy to merge.
Copy link
Copy Markdown
Collaborator Author
thanks for the review. should be fixed now.
Copy link
Copy Markdown
Owner
Not so minor in the end... thanks again for the continued efficiency gains!
Copy link
Copy Markdown
Collaborator Author
no it really was minor. I just noticed that your suggestion could help us simplify something else too.
This was a simple PR, but I'll take the 35 lines of code removed :)