Hello! In this PR I have begun writing basic support for detecting dangerous crypto algorithms. Included is a simple dataflow query as well as a library that will hopefully eventually include a variety of dangerous algorithms (I based this off of the JavaScript library for crypto). So far I have included detection for a couple of dangerous algorithms (MD5 and DES) along with respective tests, and was just hoping I could get some feedback on this before expanding upon the library. Thanks!
dilanbhalla added 2 commits
August 10, 2020 11:56
Author
I am also getting a build error when checking if all QL and Go code is autoformatted, but I have checked multiple times that all of these files have been autoformatted. Is there something else that needs to be autoformatted as well that I am missing? Thanks!
Contributor
Merged
Author
Author
dilanbhalla added 2 commits
August 11, 2020 10:34
Contributor
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contribution! This is certainly a query we'd like to have, and as an experimental contribution we hope to get it merged fairly quickly. I don't really understand a core part of the modelling, though; see my question below.
Contributor
Something went wrong with your last commit I think:
Files changed 866
Author
Hi @intrigus-lgtm, sorry about that I noticed this as soon as it pushed. Correcting it right now it should be fixed in just a minute.
Contributor
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Broadly LGTM, just a few remaining minor comments.
Author
Had a little build error there on the last submission, all fixed now though 👍
Contributor
Many thanks for your contribution!
Merged