Merged

Conversation

haby0 mentioned this pull request

Closed

2 tasks

Comment on lines +671 to +681

		DataFlow::Node getUrlArg() {
		result = this.getArgByName("url")
		or
		not methodName = "request" and
		result = this.getArg(0)
		or
		methodName = "request" and
		result = this.getArg(1)
		}

		override DataFlow::Node getAUrlPart() { result = this.getUrlArg() }

Member

I don't see any reason to have this separate predicate, can we just do

Suggested change

	DataFlow::Node getUrlArg() {
	result = this.getArgByName("url")
	or
	not methodName = "request" and
	result = this.getArg(0)
	or
	methodName = "request" and
	result = this.getArg(1)
	}

	override DataFlow::Node getAUrlPart() { result = this.getUrlArg() }
	override DataFlow::Node getAUrlPart() {
	result = this.getArgByName("url")
	or
	not methodName = "request" and
	result = this.getArg(0)
	or
	methodName = "request" and
	result = this.getArg(1)
	}

haby0 deleted the py/add-ssrf-sinks branch