added 24 commits
June 3, 2024 10:28camsim99 marked this pull request as ready for review
July 2, 2024 19:16Merged
11 tasks
Merged
Merged
11 tasks
Closed
Open
Open
Merged
4 tasks
creatorpiyush pushed a commit to creatorpiyush/packages that referenced this pull request
Jun 10, 2026…evices and set up fix for Impeller support (flutter#7044) Partially lands flutter#6856. This PR specifically includes: #### 1: A fix for correctly rotating the camera preview This fix is required for `Surface`s not backed by a `SurfaceTexture` because they don't contain the transformation information needed to correctly rotate the camera preview. In that case, we use the logic described in https://developer.android.com/media/camera/camera2/camera-preview#orientation_calculation. The fix is **not currently used** (the logic is not reachable) as Impeller support has not been added back to the plugin, but has been tested in flutter#6856 and will be turned on when flutter/flutter#149294 is fixed. Part of flutter/flutter#149294. #### 2: A fix for correctly rotating the camera preview on naturally landscape-oriented devices I believe this issue was caused because we assume that the natural orientation of the device is portrait up. We fix this here by adding an extra rotation for the camera preview based on the natural orientation of the device. Fixes flutter/flutter#149177.
creatorpiyush pushed a commit to creatorpiyush/packages that referenced this pull request
Jun 10, 2026bisor0627 pushed a commit to bisor0627/packages that referenced this pull request
Jun 19, 2026…evices and set up fix for Impeller support (flutter#7044) Partially lands flutter#6856. This PR specifically includes: #### 1: A fix for correctly rotating the camera preview This fix is required for `Surface`s not backed by a `SurfaceTexture` because they don't contain the transformation information needed to correctly rotate the camera preview. In that case, we use the logic described in https://developer.android.com/media/camera/camera2/camera-preview#orientation_calculation. The fix is **not currently used** (the logic is not reachable) as Impeller support has not been added back to the plugin, but has been tested in flutter#6856 and will be turned on when flutter/flutter#149294 is fixed. Part of flutter/flutter#149294. #### 2: A fix for correctly rotating the camera preview on naturally landscape-oriented devices I believe this issue was caused because we assume that the natural orientation of the device is portrait up. We fix this here by adding an extra rotation for the camera preview based on the natural orientation of the device. Fixes flutter/flutter#149177.