ditman · GitHub

Conversation

@ditman

Copy link Copy Markdown

Member

@ditman

ditman

Copy link Copy Markdown

Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of comments which maybe should live in the code somewhere :/

Copy link Copy Markdown

Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

composed needs to be set to true in synthetic events (similar to bubbles) so the event propagates in a similar way as to when it's dispatched by the browser. Docs.

ditman

yjbanov

Copy link Copy Markdown

Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ditman

Copy link Copy Markdown

Member Author

(This needs a rebase, to land after #82939)

Merged

9 tasks

@fluttergithubbot

Copy link Copy Markdown

Contributor

This pull request is not suitable for automatic merging in its current state.

  • The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label.

ditman

@fluttergithubbot

@ditman

ditman deleted the flutter-web-shadow-dom branch

May 20, 2021 23:28

@ditman

ditman restored the flutter-web-shadow-dom branch

May 21, 2021 00:29

@ditman

ditman deleted the flutter-web-shadow-dom branch

May 21, 2021 00:29

Read the original on github.com ↗