justinmc · GitHub

added 2 commits

February 6, 2024 10:51

@justinmc

Merged

8 tasks

…ed to its own thing on flutter/platform

hellohuanlin

… that menu must be used with text fields
…eing called too late.

@justinmc

@justinmc

justinmc added a commit that referenced this pull request

May 13, 2024

Merged

justinmc added a commit that referenced this pull request

May 13, 2024
It's now possible to use the native-rendered text selection context menu on iOS. This sacrifices customizability in exchange for avoiding showing a notification when the user presses "Paste". It's off by default, but to enable, see the example system_context_menu.0.dart.

auto-submit Bot pushed a commit that referenced this pull request

May 13, 2024

auto-submit[bot]

Merged

auto-submit Bot added a commit that referenced this pull request

May 13, 2024
Reverts: #148238
Initiated by: zanderso
Reason for reverting: Failures in post submit https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8748025189669617649/+/u/run_test.dart_for_web_canvaskit_tests_shard_and_subshard_3/stdout
Original PR Author: justinmc
Reviewed By: {hellohuanlin}
This change reverts the following previous change:
Reland of #143002, which was reverted in #148237 due to unresolved docs references. Not sure why those weren't caught in presubmit.
```
dartdoc:stdout: Generating docs for package flutter...
dartdoc:stderr:   error: unresolved doc reference [TextInput.showSystemContextMenu]
dartdoc:stderr:     from widgets.MediaQueryData.supportsShowingSystemContextMenu: (file:///b/s/w/ir/x/w/flutter/packages/flutter/lib/src/widgets/media_query.dart:579:14)
dartdoc:stderr:     in documentation inherited from widgets.MediaQueryData.supportsShowingSystemContextMenu: (file:///b/s/w/ir/x/w/flutter/packages/flutter/lib/src/widgets/media_query.dart:579:14)
dartdoc:stderr:   error: unresolved doc reference [showSystemContextMenu]
dartdoc:stderr:     from services.SystemContextMenuController.hide: (file:///b/s/w/ir/x/w/flutter/packages/flutter/lib/src/services/text_input.dart:2554:16)
dartdoc:stderr:   error: unresolved doc reference [hideSystemContextMenu]
dartdoc:stderr:     from services.SystemContextMenuController.show: (file:///b/s/w/ir/x/w/flutter/packages/flutter/lib/src/services/text_input.dart:2509:16)
```

justinmc added a commit that referenced this pull request

May 13, 2024

Merged

auto-submit Bot pushed a commit that referenced this pull request

May 15, 2024
Reverting #148238 which was relanded in #148237 which was originally from #143002.
This time post-submit I saw a failure of a wasm version of a test added by this PR.

hello-coder-xu added a commit to hello-coder-xu/flutter that referenced this pull request

May 16, 2024

TecHaxter pushed a commit to TecHaxter/flutter_packages that referenced this pull request

May 22, 2024

Open

creatorpiyush pushed a commit to creatorpiyush/packages that referenced this pull request

Jun 10, 2026

bisor0627 pushed a commit to bisor0627/packages that referenced this pull request

Jun 19, 2026

Read the original on github.com ↗