faho · GitHub

@faho

faho

faho

faho

faho

faho

faho

faho

faho

faho

faho

faho

@faho

@faho

faho marked this pull request as ready for review

August 12, 2023 15:56

henrikhorluck

@faho

@faho

event filter names, function::set_desc, common::reformat_for_screen
This is the first use for each
Turns out doing `==` on Enums with values will do a deep comparison,
including the values.
So EventDescription::Signal(SIGTERM) is !=
EventDescription::Signal(SIGWINCH).
That's not what we want here, so this does a bit of a roundabout thing.
This had an infinite loop because it had two checks broken
This encapsulates a "is our output going to the terminal" check we do
in a few places - functions, type, set_color, possibly test
And the C++ reformat_for_screen and event_filter_names as there are no more users.

@faho

@faho

@faho

faho deleted the riir-functions-2 branch

August 13, 2023 12:17

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators

Aug 12, 2024

Read the original on github.com ↗