rightaditya · GitHub

@rightaditya mentioned this pull request

Oct 8, 2025

Closed

3 tasks

krobelus

krobelus

@kerty0

@kerty0

krobelus

Commit  7db9553  (Fix regression causing off-by-one pager height on
truncated autosuggestion) adds line to pager if cursor located at
the start of line and previous line is softwrapped, even if line was
softwrapped normally and not by autosuggestion, giving pager too much space.
Fix that.
It makes it easier to do manipulations with prompt lines.

@kerty0

@kerty0

@kerty0

Instead of pretending that prompt is always 1 line, track multiline
prompt in ScreenData.visible_prompt_lines and ScreenData.line_datas as
empty lines.
This enables:
- Trimming part of the prompt that leaves the viewport.
- Removing of the old hack needed for locating first prompt line.
- Fixing fish-shell#11875.
First, print prompt marker on repaint even if prompt is not visible.
Second, if we issue a clear at (0, 0) we need to restore marker.
This is necessary for features like Kitty's prompt navigation (`ctrl-shift-{jk}`),
which requires the prompt marker at the top of the scrolled command line
to actually jump back to the original state.

@kerty0

krobelus

krobelus

krobelus pushed a commit to krobelus/fish-shell that referenced this pull request

Oct 19, 2025

krobelus pushed a commit to krobelus/fish-shell that referenced this pull request

Oct 19, 2025
Commit  7db9553  (Fix regression causing off-by-one pager height on
truncated autosuggestion) adds line to pager if cursor located at
the start of line and previous line is softwrapped, even if line was
softwrapped normally and not by autosuggestion, giving pager too much space.
Fix that.
Part of fish-shell#11911

krobelus pushed a commit to krobelus/fish-shell that referenced this pull request

Oct 19, 2025

krobelus pushed a commit to krobelus/fish-shell that referenced this pull request

Oct 19, 2025

krobelus pushed a commit to krobelus/fish-shell that referenced this pull request

Oct 19, 2025

krobelus pushed a commit to krobelus/fish-shell that referenced this pull request

Oct 19, 2025
It makes it easier to do manipulations with prompt lines.
Part of fish-shell#11911

krobelus pushed a commit to krobelus/fish-shell that referenced this pull request

Oct 19, 2025

krobelus pushed a commit to krobelus/fish-shell that referenced this pull request

Oct 19, 2025
Instead of pretending that prompt is always 1 line, track multiline
prompt in ScreenData.visible_prompt_lines and ScreenData.line_datas as
empty lines.
This enables:
- Trimming part of the prompt that leaves the viewport.
- Removing of the old hack needed for locating first prompt line.
- Fixing fish-shell#11875.
Part of fish-shell#11911

krobelus pushed a commit to krobelus/fish-shell that referenced this pull request

Oct 19, 2025

Read the original on github.com ↗