profile-conversion.test.ts was creating a snapshot file that was just a bunch
of raw profile JSONs, with around 900 000 lines total.
There's no way to catch regressions with such a test. Whenever we change the
shape of the tables in the profile format, it affects so many lines that
github's diff viewer will not render the diff, and you wouldn't be able to
meaningfully read it anyway.
For example, when I introduced the shared tables, I regressed the dhat
importer (it was overwriting some tables with empty tables), and I missed
the regression even though the test in theory "caught" it.
This commit replaces the raw profile snapshots with profile "summary"
snapshots. See the new snapshot file for examples. I think the new snapshots
are definitely more readable / reviewable, but there's also quite a bit of
new code to generate them. I'd be happy to cut back on the amount of detail
we collect when we make these summaries, to simplify that new code.
(Or maybe we can find a way to share some code with profiler-cli? Not sure.)
The new snapshot file is around 500 lines, and around 160 times smaller than
the old snapshot file.
As a second measure of defense, this commit also adds a generic profile
consistency checker function called `assertProfileIntegrity`. This would have
caught the dhat regression by itself, because nativeAllocations.stack[0] = 55
would have tripped over the stack table being empty.

Merged

canova added a commit that referenced this pull request

Jul 21, 2026

Changes:
[Sky Ning] Skip preview links for non-main PRs (#6161)
[spokodev] fix(gecko-upgrade): don't crash on a counter with empty
sample_groups (#6160)
[fatadel] Show counter values over time in profiler-cli (#6136)
[Markus Stange] Make profile-conversion snapshots more compact and
meaningful (#6152)
[Markus Stange] More typed arrays: sample + counter times, some
frametable columns (#6139)
[Nazım Can Altınova] Only render a marker url field as a link when the
whole value is a URL (#6163)
[fatadel] Show each counter's owning process in profiler-cli (#6164)
[Nazım Can Altınova] Document the pre-existing thread info and network
JSON schemas in the cli (#6171)
[Markus Stange] Copy column contents in
getRawSamplesTableBuilderFromExisting for consistency (#6168)
[Markus Stange] Convert eligible columns to typed arrays when outputting
from profiler-edit (#6167)
[Markus Stange] Remove unused samples.thread column (#6151)
[Markus Stange] Fixed botched merge which broke 'yarn ts' (#6174)
[Nazım Can Altınova] Add marker handles to `profiler-cli thread network`
(#6172)
[Markus Stange] Update json-slabs 0.3.0 → 0.4.0 (major) (#6176)
[Nazım Can Altınova] Surface network activity across profiler-cli
(#6175)
[Nazım Can Altınova] Add `profile meta` command to profiler-cli (#6177)
[Markus Stange] Allow raw marker table's `startTime` and `endTime`
columns to be Float64Array (#6169)
[nightcityblade] Fix light theme text selection colors (#6186)
[Nazım Can Altınova] Import source map URLs from Chrome DevTools traces
(#6190)
[Nazım Can Altınova] Rename yarn `build-profiler-cli` script to
`build-cli` (#6191)
[Nazım Can Altınova] Migrate husky to version 9 (#6201)
[Nazım Can Altınova] Fix horizontal overflow when the transform
navigator is long (#6199)
[fatadel] Add a 'hexadecimal' marker schema field format (#6197)
[Nazım Can Altınova] Bump source-map to 0.8.0 and remove the old type
workaround (#6202)
[Nazım Can Altınova] 🔃 Sync: l10n -> main (July 21, 2026) (#6209)
And special thanks to our localizers:
fr: parmegiani.thomas
fr: Théo Chevalier
sr: Марко Костић (Marko Kostić)
sv-SE: Luna Jernberg
tr: Grk
zh-CN: Ariel
zh-CN: Olvcpr423