RyanGlScott · GitHub

Conversation

@RyanGlScott

Copy link Copy Markdown

Contributor

I adapted the fixCodePage function for use in my standalone code-page library, and while doing so I noticed a small mix-up in its implementation. fixCodePage uses the internal functions fixInput and fixOutput to actually change the input and output codepages respectively, but while fixInput is guarded by the value setInput, fixOutput isn't guarded by setOutput—it's guarded by setInput too! This seems like a mistake, unless I'm mistaken.

RyanGlScott added a commit to RyanGlScott/code-page that referenced this pull request

Feb 14, 2017

snoyberg

@snoyberg

@snoyberg

Copy link Copy Markdown

Contributor

Thank you!

Labels

None yet

2 participants

@RyanGlScott @snoyberg

Read the original on github.com ↗