Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a critical issue where OptionManager could end up with dangling pointers after its ResetOptions method was called. The problem arose because reallocations of internal sub-objects during the reset process were not properly reflected in the registered option pointers, leading to potential crashes when attempting to write options. The changes ensure that all option pointers are correctly updated and re-registered, thereby stabilizing the option management system and preventing runtime errors.

Highlights

• Dangling Pointer Fix: Implemented a fix for dangling pointers in OptionManager by ensuring that all options are re-registered after ResetOptions is called, which prevents issues when sub-objects are reallocated.
• Option Re-registration Logic: Modified BaseOptionManager::ResetOptions to save and restore critical path options, then trigger a full re-registration of all options via Reset() and AddAllOptions() to update any raw pointers.
• Call Order Correction: Adjusted the call order within OptionManager::ResetOptions to ensure that the base class ResetOptions method is invoked after the derived class has reinitialized its specific options, thereby guaranteeing that all pointers are correctly updated.
• New Test Case: Added a new test case, WriteAfterResetOptions, to validate that OptionManager::Write() functions correctly without throwing exceptions after ResetOptions has been called, specifically addressing the dangling pointer scenario.

Changelog

• src/colmap/controllers/base_option_manager.cc
  • Saved project_path, database_path, and image_path before resetting options.
  • Called Reset() and AddAllOptions() to re-register all options and update raw pointers.
  • Restored the saved path options if reset_paths was false.
• src/colmap/controllers/option_manager.cc
  • Moved the call to BaseOptionManager::ResetOptions(reset_paths) from the beginning to the end of the OptionManager::ResetOptions method.
• src/colmap/controllers/option_manager_test.cc
  • Added a new test WriteAfterResetOptions to verify that writing options after a reset does not cause errors due to dangling pointers.

Activity

• No human activity (comments, reviews) has been recorded for this pull request yet.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩