ahojnnes ยท GitHub

Merged

Merged

Conversation

@ahojnnes

@gemini-code-assist

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly improves the resilience of the bundle adjustment process by implementing an automatic fallback mechanism. When GPU-based optimization encounters certain failure conditions, the system will now gracefully switch to using the CPU solver, preventing complete failure and ensuring that the bundle adjustment can still be completed. This enhances the overall stability and user experience, especially in environments where GPU resources might be unstable or configurations might lead to specific GPU-related errors.

Highlights

  • Robust GPU Bundle Adjustment: Introduced a SolveWithGpuFallback function that attempts to perform bundle adjustment using the GPU. If the GPU solver fails due to specific CUDA initialization, non-numeric values, or Jacobian creation issues, the system automatically retries the optimization using the CPU solver.
  • Integration into Bundle Adjusters: The new fallback logic has been integrated into both DefaultBundleAdjuster and PosePriorBundleAdjuster classes, replacing direct calls to ceres::Solve with the new SolveWithGpuFallback function.
Changelog
  • src/colmap/estimators/bundle_adjustment_ceres.cc
    • Added a new helper function SolveWithGpuFallback to encapsulate the GPU-to-CPU fallback logic for Ceres solver.
    • Updated the DefaultBundleAdjuster::Adjust method to utilize the new SolveWithGpuFallback function.
    • Updated the PosePriorBundleAdjuster::Adjust method to utilize the new SolveWithGpuFallback function.
Activity
  • No activity has been recorded for this pull request yet.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with ๐Ÿ‘ and ๐Ÿ‘Ž on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. โ†ฉ

gemini-code-assist[bot]

Closed

B1ueber2y

@ahojnnes

@ahojnnes

@ahojnnes

ahojnnes deleted the user/jsch/gpu-solver-fallback branch

March 12, 2026 19:08

Labels

None yet

Read the original on github.com โ†—