Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on enhancing the test suite for SIFT feature extraction and matching by introducing significant refactoring. The changes aim to improve the maintainability, readability, and conciseness of the tests through the use of helper functions, parameterized tests, and a dedicated GPU test runner, without altering the existing behavior or functionality of the SIFT algorithms.

Highlights

• Test Refactoring: Introduced several helper functions to encapsulate common assertions and setup logic for SIFT feature tests, significantly reducing code duplication.
• Parameterized Tests: Converted multiple individual CPU SIFT feature extraction tests into a single parameterized test suite, making it easier to add and manage test cases.
• GPU Test Utility: Implemented a RunGpuTest utility function to streamline the setup and execution of GPU-dependent tests, removing repetitive boilerplate code from individual test cases.
• Code Deduplication: Refactored various SIFT feature extraction and matching tests to leverage the new helper functions and parameterized test structure, improving overall test readability and maintainability.

Changelog

• src/colmap/feature/sift_test.cc
  • Added #include <functional> for std::function usage.
  • Introduced helper functions ValidateKeypoints, ValidateDescriptorNorms, ExpectReversedMatches, ExpectReversedInlierMatches, CreatePlanarTwoViewGeometry, and RunGpuTest to centralize common test logic.
  • Replaced multiple distinct CPU SIFT extraction tests with a single parameterized test (SiftCpuExtractionTest) using ::testing::TestWithParam.
  • Refactored existing GPU feature extraction and matching tests to utilize the new RunGpuTest helper and assertion functions, eliminating repetitive setup code.
  • Updated SiftCPUFeatureMatcher.Nominal and MatchGuidedSiftFeaturesCPU.Nominal to use the new helper functions for match assertions and geometry creation.
  • Modified MatchSiftFeaturesCPUvsGPU.Nominal to integrate the new helper functions and RunGpuTest for cleaner CPU-GPU comparison tests.

Activity

• No human activity has been recorded for this pull request yet.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩