Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly improves the user experience of the viewer by introducing drag-and-drop support for PLY files. Users can now directly drag PLY files into the application, which will then intelligently determine if the file represents a point cloud or a surface mesh and import it accordingly. This streamlines the process of loading 3D data, making the application more intuitive and efficient.

Highlights

• Drag-and-Drop Support: Implemented drag-and-drop functionality for PLY files (point clouds and surface meshes) directly into the viewer, enhancing usability.
• Intelligent PLY File Handling: Added logic to automatically detect whether a dropped PLY file represents a point cloud or a surface mesh, importing it appropriately.
• Import Function Refactoring: Refactored ImportPointCloud and ImportSurfaceMesh methods to accept a file path as an argument, allowing for programmatic import without user interaction.

• src/colmap/ui/main_window.cc
  • Updated dropEvent to parse dropped files, specifically handling .ply extensions.
  • Integrated HasPlyMeshFaces to decide whether to import a PLY file as a point cloud or a surface mesh.
  • Refactored ImportPointCloud and ImportSurfaceMesh to accept a file path as an argument, allowing direct import without a file dialog.
  • Modified QAction connections for ImportPointCloud and ImportSurfaceMesh to use QOverload for the new overloaded functions.
• src/colmap/ui/main_window.h
  • Added overloaded declarations for ImportPointCloud(const std::string&) and ImportSurfaceMesh(const std::string&) to allow direct file path imports.
• src/colmap/util/ply.cc
  • Implemented HasPlyMeshFaces function, which reads a PLY file header to determine if it contains face elements.
• src/colmap/util/ply.h
  • Declared the new HasPlyMeshFaces utility function.
• src/colmap/util/ply_test.cc
  • Added new unit tests for HasPlyMeshFaces to verify its correctness with mesh, point cloud, and zero-face PLY files.

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

ahojnnes deleted the user/jsch/drag-n-drop-ply branch