gemini-code-assist · GitHub

Add 16 new tests targeting previously uncovered code paths in
rotation_averaging.cc:
- skip_initialization option (zero-init solver path)
- HALF_NORM weight type in IRLS
- Deterministic random seed (reproducibility)
- Disabled rotation error filtering (max_rotation_error_deg <= 0)
- Empty pose graph error handling (known and unknown rig paths)
- Gravity with unknown rig sensors (AllSensorsFromRigKnown failure)
- filter_unregistered option (refinement pass)
- Stratified gravity skipped when >95% pairs have gravity
- Gravity without stratified solving
- Gravity enabled but no priors present (UseGravity false path)
- InitializeRigRotationsFromImages (multi-camera and empty input)
- Tight rotation error filtering with frame deregistration
- Edge invalidation by relative rotation error
- Unknown rig with noise (expanded reconstruction path)

gemini-code-assist[bot]

@ahojnnes

Increase num_frames_per_rig from 5 to 15 to make the IRLS system
better conditioned with HALF_NORM weights, fixing CHOLMOD
non-positive-definite failures on macOS. Also fix clang-format issues.

@ahojnnes

@ahojnnes

ahojnnes marked this pull request as ready for review

March 6, 2026 12:59

B1ueber2y

@ahojnnes

@ahojnnes

@ahojnnes

@ahojnnes

ahojnnes deleted the user/jsch/rotation-averaging-test branch

March 7, 2026 08:06

Read the original on github.com ↗