ahojnnes · GitHub

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly enhances the test coverage for the bundle adjustment module. It introduces a suite of new unit tests for the BundleAdjustmentConfig class, validating the behavior of its image, camera intrinsic, rig pose, and point management functionalities. Additionally, a test for the BundleAdjustmentSummary's reporting capability has been added, contributing to the robustness and reliability of the bundle adjustment process.

Highlights

  • Expanded BundleAdjustmentConfig Tests: Added new unit tests for various BundleAdjustmentConfig methods, including AddRemoveImage, SetConstantCamIntrinsics, SetVariableCamIntrinsics, SetConstantSensorFromRigPose, SetVariableSensorFromRigPose, SetConstantRigFromWorldPose, SetVariableRigFromWorldPose, AddVariablePoint, AddConstantPoint, RemoveVariablePoint, RemoveConstantPoint, IgnorePoint, FixGauge, and Images.
  • BundleAdjustmentSummary Test: Included a new test case for BundleAdjustmentSummary::BriefReport to verify its output.
Changelog
  • src/colmap/estimators/bundle_adjustment_test.cc
    • Added new tests for BundleAdjustmentConfig::AddRemoveImage
    • Added new tests for BundleAdjustmentConfig::SetConstantCamIntrinsics and SetVariableCamIntrinsics
    • Added new tests for BundleAdjustmentConfig::SetConstantSensorFromRigPose and SetVariableSensorFromRigPose
    • Added new tests for BundleAdjustmentConfig::SetConstantRigFromWorldPose and SetVariableRigFromWorldPose
    • Added new tests for BundleAdjustmentConfig::AddVariablePoint, AddConstantPoint, RemoveVariablePoint, and RemoveConstantPoint
    • Added new tests for BundleAdjustmentConfig::IgnorePoint
    • Added new tests for BundleAdjustmentConfig::FixGauge
    • Added new tests for BundleAdjustmentConfig::Images
    • Added new tests for BundleAdjustmentSummary::BriefReport
Activity
  • No activity has been recorded for this pull request yet.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

Read the original on github.com ↗