Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a build configuration oversight by integrating previously missing source files from the cost_functions and solvers subdirectories within the estimators module into the CMake project. This ensures that all necessary components are correctly compiled and linked, resolving potential compilation errors or missing symbol issues for dependent modules.

Highlights

• CMake Configuration Update: Two new COLMAP_ADD_SOURCE_DIR commands were added to include source files from src/colmap/estimators/cost_functions and src/colmap/estimators/solvers into the build system.
• Build System Source Inclusion: The variables corresponding to the newly added source directories, ESTIMATORS_COST_FUNCTIONS_SRCS and ESTIMATORS_SOLVERS_SRCS, were incorporated into the ALL_SRCS list, ensuring these files are part of the ALL_SOURCE_TARGET.

• CMakeLists.txt
  • Added COLMAP_ADD_SOURCE_DIR for src/colmap/estimators/cost_functions.
  • Added COLMAP_ADD_SOURCE_DIR for src/colmap/estimators/solvers.
  • Included ESTIMATORS_COST_FUNCTIONS_SRCS in the ALL_SRCS variable.
  • Included ESTIMATORS_SOLVERS_SRCS in the ALL_SRCS variable.

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

ahojnnes deleted the user/jsch/estimator-srcs branch