Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves a regression by reintroducing explicit namespace qualifications for several file utility functions within their respective THROW_CHECK macros. This ensures that functions like ExistsFile, ExistsDir, and HasFileExtension are correctly resolved to the colmap namespace, preventing compilation errors and maintaining code integrity.

Highlights

Namespace Qualification: Explicitly qualified ExistsFile, ExistsDir, and HasFileExtension functions with the colmap:: namespace within their respective THROW_CHECK macros.
Regression Fix: Addressed a regression where the colmap namespace qualification was missing from utility functions used in macros, which had previously been fixed but reappeared.

Changelog

src/colmap/util/file.h
- Added colmap:: namespace prefix to ExistsFile within the THROW_CHECK_FILE_EXISTS macro.
- Added colmap:: namespace prefix to ExistsDir within the THROW_CHECK_DIR_EXISTS macro.
- Added colmap:: namespace prefix to HasFileExtension within the THROW_CHECK_HAS_FILE_EXTENSION macro.

Activity

No human activity has been recorded on this pull request yet.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

Comment on lines +42 to +44

Comment on lines +46 to +48

Comment on lines 60 to 63

		#define THROW_CHECK_HAS_FILE_EXTENSION(path, ext) \
		THROW_CHECK(HasFileExtension(path, ext)) \
		THROW_CHECK(colmap::HasFileExtension(path, ext)) \
		<< "Path " << (path) << " does not match file extension " << (ext) \
		<< "."