Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly enhances the robustness of option registration by shifting type validation from runtime to compile-time. This change ensures that unsupported option types are detected during compilation, preventing potential runtime crashes and simplifying debugging. It also includes minor type adjustments in related executable files to align with these new compile-time checks, improving overall type safety.

Highlights

• Compile-time Type Checking: Implemented compile-time type checking for option registration, replacing runtime fatal errors with static_assert for unsupported option types.
• Type Adjustments: Adjusted integer types from size_t to int in image.cc and sfm.cc to ensure compatibility and prevent potential issues with option registration.
• Metaprogramming Utility: Introduced a new always_false template struct in types.h to facilitate the use of static_assert with dependent types.

• src/colmap/controllers/base_option_manager.h
  • Replaced a runtime LOG(FATAL_THROW) with a compile-time static_assert for handling unsupported option types during registration.
• src/colmap/exe/image.cc
  • Changed the type of min_num_observations from size_t to int.
  • Updated the comparison image.NumPoints3D() >= min_num_observations to include a static_cast<size_t> for the min_num_observations variable.
• src/colmap/exe/sfm.cc
  • Changed the type of min_track_len from size_t to int.
• src/colmap/util/types.h
  • Added a new template struct always_false which inherits from std::false_type, intended for use with static_assert.

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.