Summary of Changes

Hello @whuaegeanse, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a critical CMake build error encountered when compiling COLMAP with ONNX Runtime on Windows, specifically related to the installation of the ONNX Runtime's 'share' directory. The changes improve the robustness of the ONNX Runtime integration by ensuring that installation steps are only performed when necessary and by correctly handling library installations for Windows, leading to a more stable and reliable build process.

Highlights

• Build Error Fix: Resolved a CMake error where file INSTALL cannot find "xx/colmap-x64/_deps/onnxruntime-build/share": File exists. by adding an existence check before attempting to install the ONNX Runtime share directory.
• ONNX Runtime Configuration: Refactored the setting of onnxruntime_CONFIG_DIR_HINTS in FindDependencies.cmake to ensure it is correctly defined within the ONNX-specific logic.
• Windows Library Installation: Implemented conditional installation of ONNX Runtime .lib files for Windows builds, including core libraries and CUDA provider libraries when CUDA is enabled.
• CMake Configuration Cleanup: Removed redundant ONNX Runtime path configurations from colmap-config.cmake.in, streamlining the build setup.

• cmake/FindDependencies.cmake
  • Moved the definition of onnxruntime_CONFIG_DIR_HINTS to an earlier point within the ONNX-enabled block.
  • Added a new installation block for Windows to selectively install ONNX Runtime .lib files, including onnxruntime.lib, onnxruntime_providers_shared.lib, and conditionally onnxruntime_providers_cuda.lib.
  • Wrapped the install(DIRECTORY ... TYPE DATA) command for the ONNX Runtime share directory with an if(EXISTS ...) condition to prevent installation errors if the directory does not exist.
• cmake/colmap-config.cmake.in
  • Removed the conditional block that set onnxruntime_DIR, onnxruntime_INCLUDE_DIR_HINTS, and onnxruntime_LIBRARY_DIR_HINTS when FETCH_ONNX was enabled, as these are now handled elsewhere.

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

…with CUDA and TensorRT

…ry and DLL installation conditions