Summary of Changes

Hello @StonerLing, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly refactors the logging configuration by introducing a more structured set of command-line options within BaseOptionManager, allowing for finer control over log output destinations, paths, levels, and colors. It also addresses a specific formatting bug in the UI's log display and enhances the C++ formatting script for better robustness with numerous files.

Highlights

• Revamped Logging Configuration: Introduced a new, more granular set of logging options (Logging.log_target, path, level, severity, color) within BaseOptionManager, replacing older flags and providing finer control over log output destinations and behavior. This includes a new ApplyLogFlags method to manage glog integration.
• Fixed UI Log Sink Formatting: Corrected an issue in src/colmap/ui/log_widget.cc where log messages were not correctly formatted after the severity prefix in the UI, ensuring proper display of log entries.
• Improved C++ Formatting Script: Updated scripts/format/c++.sh to utilize xargs, resolving potential 'Argument list too long' errors that could occur when formatting a large number of files.

Changelog

• doc/cli.rst
  • Updated CLI documentation to reflect the new Logging.log_target, Logging.log_path, Logging.log_level, Logging.log_severity, and Logging.log_color options.
  • Removed the deprecated --log_to_stderr and --log_level options from the documentation.
• scripts/format/c++.sh
  • Modified the C++ formatting script to use echo "$all_files" | xargs clang-format -i to prevent 'Argument list too long' errors.
• src/colmap/controllers/base_option_manager.cc
  • Replaced old log_to_stderr and log_level options with new Logging.log_target, Logging.log_path, Logging.log_level, Logging.log_severity, and Logging.log_color options.
  • Implemented a new ApplyLogFlags method to map the simplified log target options to glog flags.
  • Added logic to create the log directory if log_target is set to file or stderr_and_file.
  • Integrated ApplyLogFlags into the Parse method to ensure logging configurations are applied.
• src/colmap/controllers/base_option_manager.h
  • Added a std::string log_target_ member variable with a default value of 'stderr_and_file'.
  • Declared the ApplyLogFlags() method to manage the application of logging settings.
• src/colmap/controllers/base_option_manager_test.cc
  • Introduced a new test suite TEST(BaseOptionManager, LogOptions) to verify the functionality of the new logging options.
  • Added a VerifyLogState helper function to assert the correct glog flag states for different log_target inputs.
• src/colmap/ui/log_widget.cc
  • Corrected the std::copy operation within GlogSink::Send to properly place log messages after the severity prefix, fixing a UI formatting bug.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩