gemini-code-assist · GitHub

Summary of Changes

Hello @ahojnnes, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly expands the Python API for COLMAP by introducing comprehensive bindings for its feature matching functionalities. It allows Python users to instantiate and configure various feature matchers, including those leveraging ONNX models, and perform both standard and guided feature matching operations between images. This integration enhances COLMAP's usability within Python-based computer vision workflows.

Highlights

  • Python Bindings for FeatureMatcher: Introduced Python bindings for the FeatureMatcher class, enabling Python users to utilize COLMAP's feature matching capabilities directly.
  • ONNX-Enabled Matcher Options: Added Python bindings for ONNX-specific matching options, including BruteForceONNXMatchingOptions, LightGlueONNXMatchingOptions, and AlikedMatchingOptions, which are conditionally available when COLMAP is compiled with ONNX support.
  • FeatureMatcherType Enum: Exposed the FeatureMatcherType enum to Python, allowing users to specify different matching algorithms like SIFT_BRUTEFORCE, ALIKED_BRUTEFORCE, etc.
  • Enhanced Matching Options: Updated SiftMatchingOptions and FeatureMatchingOptions to include new parameters related to LightGlue and ALIKED matching, providing more control over the matching process.
  • Match and MatchGuided Methods: Implemented match and match_guided methods for the Python FeatureMatcher class, facilitating feature matching between images and guided matching using existing two-view geometry.
Changelog
  • src/pycolmap/feature/matching.cc
    • Included new headers for colmap/feature/matcher.h, and conditionally colmap/feature/aliked.h and colmap/feature/onnx_matchers.h.
    • Added PyFeatureMatcher trampoline class to enable Python inheritance for FeatureMatcher.
    • Bound the FeatureMatcherType enum, exposing various matching algorithm types.
    • Conditionally bound BruteForceONNXMatchingOptions, LightGlueONNXMatchingOptions, and AlikedMatchingOptions classes, along with their respective members and check methods.
    • Modified SiftMatchingOptions to conditionally include a lightglue option.
    • Updated FeatureMatchingOptions to accept FeatureMatcherType in its constructor and conditionally added an aliked member.
    • Bound the FeatureMatcher class, its nested Image class (with constructors and properties), and its create, match, and match_guided methods.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

Read the original on github.com ↗