…eLoadImages

tavislocus pushed a commit to tavislocus/colmap_6dof that referenced this pull request

Aug 22, 2025

This PR fixs the bug of using skip_image_pairs_in_same_frame=true
```
   // Avoid self-matches within a frame.
    if (matching_options_.skip_image_pairs_in_same_frame) {
      const Image& image1 = cache_->GetImage(image_id1);
      const Image& image2 = cache_->GetImage(image_id2);
      if (image1.FrameId() == image2.FrameId()) {
        continue;
      }
    }
```
The image's frame ID is not set in MaybeLoadImages. The default value
for all images is the same, causing all pairs to be skipped.
Solution:
1. Set the image's frame ID in MaybeLoadImages.
2. Check the validity of the image's frame ID before comparing.
---------
Co-authored-by: Johannes Schönberger <jsch@demuc.de>

Merged