whuaegeanse · GitHub

@whuaegeanse

Copy link Copy Markdown

Contributor

  1. Fix ReadPositionPriorData to return valid and numerically more stable Position prior data.
  2. Adjust the unit test of SpatialPairGenerator to test that the matrix returned by ReadPositionPriorData has the correct number of rows.
… Position prior data

ahojnnes

ahojnnes

ahojnnes

ahojnnes

Copy link Copy Markdown

Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the fix. The implementation indeed had a bug. Left some comments.

@whuaegeanse

Copy link Copy Markdown

Contributor Author

Thank you for the fix. The implementation indeed had a bug. Left some comments.

The bug in this PR has been fixed.

@ahojnnes

Copy link Copy Markdown

Contributor

@whuaegeanse Thank you, I pushed another commit with some improvements and an explicit test for large coordinates.

@ahojnnes

@ahojnnes

ahojnnes

@ahojnnes

Merged

@whuaegeanse

Read the original on github.com ↗