Copy link
Copy Markdown
Contributor
- Fix ReadPositionPriorData to return valid and numerically more stable Position prior data.
- Adjust the unit test of SpatialPairGenerator to test that the matrix returned by ReadPositionPriorData has the correct number of rows.
Copy link
Copy Markdown
Contributor
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the fix. The implementation indeed had a bug. Left some comments.
Copy link
Copy Markdown
Contributor Author
Thank you for the fix. The implementation indeed had a bug. Left some comments.
The bug in this PR has been fixed.
Copy link
Copy Markdown
Contributor
@whuaegeanse Thank you, I pushed another commit with some improvements and an explicit test for large coordinates.