Copy link Copy Markdown

Contributor

1.Fix the bug in ObservationManager::FilterPoints3DWithSmallTriangulationAngle where the count of observations filtered by triangulation angle was incorrect.
2. Renamed num_filtered to num_filtered_observations to better express the meaning of the variable.

ahojnnes changed the title ~~Fix ObservationManager~~ Fix FilterPoints3DWithSmallTriangulationAngle to return number of filtered observations

Jun 28, 2025

Copy link Copy Markdown

Contributor

Thank for catching this bug, the fix look valid to me. Ideally, we would adjust the unit tests to catch this issue by checking the return values of the filtering function calls. Is this something you could add as part of this PR? Thank you.

Copy link Copy Markdown

Contributor Author

The unit tests of filtering functions have been adjusted.

Copy link Copy Markdown

Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

…rvationManager

Merged