Contributor
Without the custom main function introduced in this PR, we get warnings about glog not being initialized, since the default gtest/gmock main functions do not initialize glog.
Member
Nice! Are the test failures related? Does it mean that tests have been silently failing on Windows?
Contributor Author
Nice! Are the test failures related? Does it mean that tests have been silently failing on Windows?
I am afraid that this might be the case. I don't have access to a Windows machine right now though :-) Will need to setup a virtual machine to debug the issues.
…h/gtest-main-glog-init
Contributor Author
@sarlinpe I fixed the Windows test failures. They were related in the sense that we didn't fail on test failures under Windows before the custom gtest main function.
