ahojnnes · GitHub

@ahojnnes

Copy link Copy Markdown

Contributor

Fixes the following warnings triggered on almost every file because of transitive includes:

colmap/scene/reconstruction.h(279): warning C4101: 'e': unreferenced local variable

@ahojnnes

sarlinpe

Copy link Copy Markdown

Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks! Shouldn't have this been caught by ClangTidy?

B1ueber2y

@ahojnnes

Copy link Copy Markdown

Contributor Author

Nice, thanks! Shouldn't have this been caught by ClangTidy?

There may be no check implemented for this or we have not activated it. In theory, I agree, that this is something that it should be able to detect.

@ahojnnes

@ahojnnes

ahojnnes deleted the user/jsch/windows-reconstruction-exc-warning branch

November 4, 2024 08:45

@sarlinpe

Copy link Copy Markdown

Member

Merged

Read the original on github.com ↗