ahojnnes · GitHub

@ahojnnes

Copy link Copy Markdown

Contributor

  • Resolves some TODOs by adding missing methods, etc.
  • Moves the implementation of various __repr__ to the C++ side.
  • Makes Correspondence a data class to benefit from automatic __copy__ method creation.
  • Makes Database object compatible with context manager interface to enable with pycolmap.Database("path.db") as db usage.
  • Some backwards compatibility breakage to achieve consistent method names in C++ and Python.
…h/pycolmap-improvements

ahojnnes

@ahojnnes

B1ueber2y

Copy link Copy Markdown

Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. LGTM

sarlinpe

@ahojnnes

sarlinpe

Copy link Copy Markdown

Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice improvements, thanks!

@ahojnnes

@ahojnnes

@ahojnnes

ahojnnes deleted the user/jsch/pycolmap-improvements branch

October 26, 2024 09:47

Merged

Read the original on github.com ↗