B1ueber2y · GitHub

@B1ueber2y

Copy link Copy Markdown

Contributor

@B1ueber2y

@B1ueber2y

@sarlinpe sarlinpe linked an issue

Sep 11, 2024

that may be closed by this pull request

Closed

@ahojnnes

Copy link Copy Markdown

Contributor

Is it possible to construct a test case that covers the issue? Thanks for the fix.

@B1ueber2y

Copy link Copy Markdown

Contributor Author

Is it possible to construct a test case that covers the issue? Thanks for the fix.

Added some tests in the reconstruction class (we need to add some pipeline tests in the future). PTAL when time permits. The point_triangulator breaks in the current head so we should merge this PR ASAP : )

@B1ueber2y

ahojnnes

Copy link Copy Markdown

Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, small suggestion. Otherwise, LGTM.

ahojnnes

@ahojnnes

@ahojnnes

ahojnnes

@B1ueber2y

Merged

Read the original on github.com ↗