sarlinpe · GitHub

@sarlinpe

Copy link Copy Markdown

Member

Major simplification of IncrementalMapperController:Reconstruct. This should make it easier to rewrite it in Python (next step). The logical behavior of the function is unchanged.
cc @B1ueber2y

@sarlinpe

@sarlinpe

@sarlinpe

@sarlinpe

sarlinpe marked this pull request as ready for review

February 15, 2024 13:35

@sarlinpe

@sarlinpe

@sarlinpe

B1ueber2y

B1ueber2y

@B1ueber2y

Copy link Copy Markdown

Contributor

Thanks. Huge step. Wrapping the logics from the controller into the sfm incremental mapper makes a lot of sense. After the simplification the whole logic looks better than before.

ahojnnes

@sarlinpe

ahojnnes

Copy link Copy Markdown

Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merci, lgtm

@sarlinpe

@sarlinpe

sarlinpe deleted the sarlinpe/cleanup-inc-mapper-ctrl branch

February 19, 2024 07:49

Read the original on github.com ↗