sarlinpe · GitHub

@sarlinpe

Copy link Copy Markdown

Member

I'm on Ubuntu 18.04 and seeing the extra -fPIC flag added by Qt 5.9.5, as reported in #1753 #1813. Upgrading to cmake 3.26 does not help. I think that it's safer to remove the flag regardless of the Qt version.

@sarlinpe

Closed

@ahojnnes

Copy link Copy Markdown

Contributor

Are you stuck with 18.04? I was planning to not support 18.04 going forward, as its outdated default compiler/packages hold development back due to lack of C++14, etc.

@sarlinpe

Copy link Copy Markdown

Member Author

Nope I indeed need to update very soon... But I don't think that this issue is specific to Ubuntu 18.04.

@ahojnnes

Copy link Copy Markdown

Contributor

I would rather add the 5.9.5 version explicitly, as it does appear to be fixed for the Qt version under 20.04 and 22.04. It sounds a little dangerous to mess with the default flags across all versions.

@ahojnnes

@ahojnnes

@ahojnnes

Copy link Copy Markdown

Contributor

Looked at the cmake bug again and also the special casing here. I think we can go ahead as proposed by you. Apologies , didn't have time to look with necessary detail yesterday. Thanks.

auto-merge was automatically disabled

July 11, 2023 07:33

Head branch was pushed to by a user without write access

@ahojnnes

@sarlinpe

Read the original on github.com ↗