DavertMik ยท GitHub

Commits on May 23, 2026

  1. fixed esm compatible def (#5576)

    * fixed esm compatible def
    * test: stop hitting codecept.io live site for flake-prone selectors
    The .frameworks/.mountains/[alt="React"] and .logo selectors no longer
    exist on the new codecept.io homepage, so two specs went red:
    - Playwright_test.js: 'should wait for invisible combined with dontseeElement'
    - WebDriver_test.js: 'should check text is not equal to empty string of element text'
    Point both at the local /info fixture using elements that already exist
    there (#grab-multiple, a[id="first-link"], #grab-css, #p-no-text).
    Same assertions, no external network dependency.
    Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
    ---------
    Co-authored-by: DavertMik <davert@testomat.io>
    Co-authored-by: Claude Opus 4.7 <noreply@anthropic.com>

    3 people authored

    May 23, 2026
    Configuration menu

    Browse the repository at this point in the history

  2. Fix retryFailedStep ignoredSteps exact-name matching (#5571)

    * Fix retryFailedStep ignoredSteps exact-name matching
    The wildcard check used `ignored.indexOf('*')` as a boolean. `-1` is
    truthy in JavaScript (only `0` is falsy), so entries without `*` were
    matched via `startsWith(slice(0, -1))` instead of exact compare, which
    also chops the last character โ€” broadening the match further.
    `ignoredSteps: ['see']` silently ignored `seeElement`, `seeInField`,
    `selectOption`, `sendPostRequest` โ€” anything starting with `se`.
    Compare against `-1` explicitly so exact-name entries only match
    themselves, as the docs describe.
    * fix(retryFailedStep): avoid mutating shared defaultConfig
    Each call to retryFailedStep mutated the module-level defaultConfig via
    Object.assign(defaultConfig, config), so config.when from a prior call leaked
    into the next as customWhen and chained recursively. In tests this made
    when() return undefined for closures that no longer had a live step.started
    listener (e.g. after event.cleanDispatcher), causing the new regression test
    to fail in the full unit suite even though it passed in isolation.
    Use Object.assign({}, defaultConfig, config) so each registration gets an
    independent config object. Rewrites the regression test to assert via
    retryConfig.when() directly, which is now sound.
    Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
    ---------
    Co-authored-by: Michael Bodnarchuk <davert.ua@gmail.com>
    Co-authored-by: Claude Opus 4.7 <noreply@anthropic.com>

    3 people authored

    May 23, 2026
    Configuration menu

    Browse the repository at this point in the history

Read the original on github.com โ†—