edwinsolisf · GitHub

Conversation

@edwinsolisf

Copy link Copy Markdown

Contributor

The header included in math.hpp in all backends does not include depending on the standard library implementation. is required for the preprocessor defined limit constants.

Description

  • Is this a new feature or a bug fix?: Bug fix
  • Why these changes are necessary: fixes possible include errors when compiling with some compilers
  • Potential impact on specific hardware, software or backends: all backends
  • New functions and their functionality: None
  • Can this PR be backported to older versions?: Yes
  • Future changes not implemented in this PR: None
    Fixes: [Build] Error : missing lib #include <climits> #3543

Changes to Users

  • Additional options added to the build: None
  • No action required by the user

Checklist

  • Rebased on latest master
  • Code compiles
  • Tests pass
  • Functions added to unified API
  • Functions documented

@edwinsolisf

@christophe-murphy

christophe-murphy

@christophe-murphy

Merged

2 participants

@edwinsolisf @christophe-murphy

Read the original on github.com ↗