edwinsolisf · GitHub

@edwinsolisf

Copy link Copy Markdown

Contributor

Adds #include <cassert> in err_common.hpp to fix assert macro not being defined when compiling in Debug with Visual Studio in Windows.

Description

  • Is this a new feature or a bug fix?: Bug fix
  • Why these changes are necessary: correctly includes the assert macro
  • Potential impact on specific hardware, software or backends: fixes issue with Microsoft Visual Studio compiler with assert macro
  • New functions and their functionality.
  • Can this PR be backported to older versions?
  • Future changes not implemented in this PR.

Fixes: #3556

Changes to Users

  • No options added to build
  • No action required by the user

Checklist

  • Rebased on latest master
  • Code compiles
  • Tests pass
  • Functions added to unified API
  • Functions documented

@edwinsolisf

christophe-murphy

@christophe-murphy

Read the original on github.com ↗