Contributor
Adds the threads options to OPENBLAS & FFT VCPKG compilation.
Description
- Improvement, by specializing options during VCPKG compilation
Changes to Users
Improved speed when using OPENBLAS.
Checklist
- Rebased on latest master
- Code compiles
- Tests pass
- [-] Functions added to unified API
- [-] Functions documented
| "description": "Build OpenCL backend", | ||
| "dependencies": [ | ||
| "boost-compute", | ||
| "boost-program-options", |
Member
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this is a good dependency for the project. It is only required for some of the tests in the clFFT project and those aren't built. I think the vcpkg should minimize the number of dependencies installed whenever possible.
Contributor Author
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK.
I get it out, and resend the PR.
Contributor Author
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or should I move it to the openblasfftw section ?
Member
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should remove it. We don't need that dependency to build ArrayFire.
Contributor Author
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, done
