Copy link
Copy Markdown
Member
Fix tests and improve the AF_WITH_FAST_MATH option in OpenCL and CUDA
Description
- Pass fast math flag to nvcc
- Pass fast math flag to nvrtc
- Pass fast math flag to OpenCL
- Fix min and max function when AF_WITH_FAST_MATH is set because infinity doesn't exist with fast math
- Set cuBLAS math mode to CUBLAS_TF32_TENSOR_OP_MATH when AF_WITH_FAST_MATH is set
Changes to Users
N/A
Checklist
- Rebased on latest master
- Code compiles
- Tests pass
[ ] Functions added to unified API[ ] Functions documented
Copy link
Copy Markdown
Member
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we have any fast mode specific tests ?
Copy link
Copy Markdown
Member Author
We don't have fast math specific tests. I am not sure how we could write one. We can lower precision but I don't think that will be helpful. A lot of tests still fail with these changes. I am not sure if we can fix all of them.
Copy link
Copy Markdown
Contributor