9prady9 · GitHub

@umar456

Copy link Copy Markdown

Member

The Intel compiler uses fast math by default in order to perform some optimization. These
optimizations causes some of our tests to fail. This PR handles several of the issues
brought up with the new compiler

Description

  • Add AF_WITH_FAST_MATH to options which enable the use of fast math flags in all compilers. This is off by default
  • Fix several warnings with clang and icx
  • Refactor GitHub actions so that the builds only execute if clang-format and docs pass
  • Add additional compilers to GitHub actions

Changes to Users

  • Users can now enable AF_WITH_FAST_MATH for additional performance at the cost of precision

Checklist

  • Rebased on latest master
  • Code compiles
  • Tests pass
  • [ ] Functions added to unified API
  • [ ] Functions documented

9prady9

Copy link Copy Markdown

Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did a quick pass, lgtm

@umar456

@umar456

Copy link Copy Markdown

Member Author

Addressed all feedback.

@umar456

syurkevi

@umar456

Read the original on github.com ↗