Without the additional toolset argument being forwarded to msvc toolchain, cmake/msvc is free to choose a toolset as per their respective logic. This causes build issues. Also fixed some conditions that are based on CMakeBuildType variable - not recommended to use checks based on that variable and often resulted in issues when used with untested multi-config generators.
9prady9 deleted the win_ocl_ext_project_fixes branch
February 12, 2021 02:509prady9 added a commit to 9prady9/arrayfire that referenced this pull request
Aug 2, 2021
* Fix cmake arguments for external projects for msvc Without the additional toolset argument being forwarded to msvc toolchain, cmake/msvc is free to choose a toolset as per their respective logic. This causes build issues. Also fixed some conditions that are based on CMakeBuildType variable - not recommended to use checks based on that variable and often resulted in issues when used with untested multi-config generators. (cherry picked from commit 422f1bd )
syurkevi pushed a commit that referenced this pull request
Dec 28, 2021
* Fix cmake arguments for external projects for msvc Without the additional toolset argument being forwarded to msvc toolchain, cmake/msvc is free to choose a toolset as per their respective logic. This causes build issues. Also fixed some conditions that are based on CMakeBuildType variable - not recommended to use checks based on that variable and often resulted in issues when used with untested multi-config generators. (cherry picked from commit 422f1bd )