9prady9 · GitHub

@9prady9

Copy link Copy Markdown

Member

Description

Indexing a const array inside GFOR produced results which aren't identical to results generated from indexing a non-const array.
Fixes: #3073

Changes to Users

Identical behavior when indexing const vs non-const array inside gfor.

Checklist

  • Rebased on latest master
  • Code compiles
  • Tests pass - test_inverse_dense_opencl seems to fail after this change, looking into it why, although the specific failing test seems to run fine if run via filter argument to the test program.
  • [ ] Functions added to unified API
  • [ ] Functions documented

@9prady9

@9prady9

Copy link Copy Markdown

Member Author

Doesn't seem like inverse_dense failure on my local machine is related to this change. I think somehow cpu_randu helper is causing it because if I don't use it and use GPU function to generate data for inverse_dense, the tests pass in every run just fine.

@9prady9

9prady9 marked this pull request as ready for review

January 13, 2021 01:27

@9prady9

@9prady9

umar456

@9prady9

@9prady9

Read the original on github.com ↗