Remove the check that ensures that the filter type and signal type have to be the same.
Description
The filter and signal type need to be the same to function properly but ArrayFire used to perform implicit conversions if the filter type does not match the signal type. A check was added in the previous release that added an assert to enforce the same type which broke some code. This PR removes that check.
This sort of thing should warn the user in case this is being performed. We can also add a flag that does perform these checks for users who are concerned about these types of conversions. Although the performance impact of performing these types of conversions are minimal.
Changes to Users
Users do not explicitly have to convert the filter to the signal type before calling fftconvolve
Checklist
- Rebased on latest master
- Code compiles
- Tests pass
[ ] Functions added to unified API[ ] Functions documented