jacobkahn added a commit to jacobkahn/flashlight that referenced this pull request

May 6, 2020

Summary:
Needed changes to CMake files to support a flashlight Conan package.
Support adding `CONAN_PKG::[package]` where needed. Conan pulls in ArrayFire (see arrayfire/arrayfire#2875, in progress) along with OpenMPI, Cereal, and Google Test, so conditionally find/pull in those deps based on if those Conan package imported targets exist.
Differential Revision: D21425652
fbshipit-source-id: ec30de11eac4864fa42195de922bd3b8cd654cf9

Closed

umar456 pushed a commit to umar456/arrayfire that referenced this pull request

Jun 27, 2020

…ler (arrayfire#2875)
* Add an ArrayFire conanfile.py that pulls from the linux binary installer
* Make backends and graphics opt-in/out, use variables for lib versioning

Merged

2 tasks

9prady9 pushed a commit that referenced this pull request

Jun 27, 2020

…ler (#2875)
* Add an ArrayFire conanfile.py that pulls from the linux binary installer
* Make backends and graphics opt-in/out, use variables for lib versioning

jacobkahn added a commit to jacobkahn/flashlight that referenced this pull request

Jul 5, 2020

Summary:
Pull Request resolved: flashlight#119
Needed changes to CMake files to support a flashlight Conan package.
Support adding `CONAN_PKG::[package]` where needed. Conan pulls in ArrayFire (see arrayfire/arrayfire#2875, in progress) along with OpenMPI, Cereal, and Google Test, so conditionally find/pull in those deps based on if those Conan package imported targets exist.
Reviewed By: vineelpratap
Differential Revision: D21425652
fbshipit-source-id: b70e869c87e2ad582424c6a8288c29ca05ffdae8

jacobkahn added a commit to jacobkahn/flashlight that referenced this pull request

Jul 7, 2020

Summary:
Pull Request resolved: flashlight#119
Needed changes to CMake files to support a flashlight Conan package.
Support adding `CONAN_PKG::[package]` where needed. Conan pulls in ArrayFire (see arrayfire/arrayfire#2875, in progress) along with OpenMPI, Cereal, and Google Test, so conditionally find/pull in those deps based on if those Conan package imported targets exist.
Reviewed By: vineelpratap
Differential Revision: D21425652
fbshipit-source-id: 945cda8baffe2e595f71901133d72208d8388d96

facebook-github-bot pushed a commit to flashlight/flashlight that referenced this pull request

Jul 7, 2020

Summary:
Pull Request resolved: #119
Needed changes to CMake files to support a flashlight Conan package.
Support adding `CONAN_PKG::[package]` where needed. Conan pulls in ArrayFire (see arrayfire/arrayfire#2875, in progress) along with OpenMPI, Cereal, and Google Test, so conditionally find/pull in those deps based on if those Conan package imported targets exist.
Reviewed By: vineelpratap
Differential Revision: D21425652
fbshipit-source-id: 4d13b5bcb7f5420527214c2f4ca5deda034d0da5

facebook-github-bot pushed a commit to flashlight/flashlight that referenced this pull request

Jul 7, 2020

Summary:
Adds Conan support on flashlight. This is on the heels of Conan support for ArrayFire (arrayfire/arrayfire#2875). Note that that PR doesn't need to land for this to be viable, since I'll be uploading the ArrayFire package to the `conan-community` remote one of these days
I'll also add `flashlight/0.1` to the [`conan-community` remote](https://docs.conan.io/en/latest/uploading_packages/remotes.html#conan-community) eventually as well.
Note that only the CUDA backend is supported right now (the AF binary installer provides non-CUDA-RT CUDA libraries) -- MKL-DNN has no Conan support
Build is also Linux-based only for now. The AF binary installer used is for Linux.
Reviewed By: andresy, vineelpratap
Differential Revision: D21427691
fbshipit-source-id: e85f6911b3e3340db339fae5520112a1d2b2af09