WilliamTambellini · GitHub

umar456 commented
Jul 15, 2019

Copy link Copy Markdown

Member

No description provided.

WilliamTambellini previously approved these changes Jul 15, 2019

View reviewed changes

umar456 dismissed WilliamTambellini’s stale review via ef937c3

July 16, 2019 01:13

umar456 force-pushed the unary branch from c9c9516 to ef937c3 Compare

July 16, 2019 01:13

Add f16 support for unary types

umar456 force-pushed the unary branch from ef937c3 to a94e2fe Compare

July 16, 2019 04:46

9prady9 requested changes Jul 16, 2019

View reviewed changes

9prady9 left a comment

Copy link Copy Markdown

Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Except the comment on test/math.cpp everything else looks good.

windows/math_cpu job failed on some trignometric operations.
https://ci.arrayfire.org/testDetails.php?test=174546&build=1864

Comment thread

src/api/c/implicit.cpp Outdated

Comment thread

src/backend/cuda/math.hpp

Comment thread

Addressed feedback

9prady9 mentioned this pull request

Fix random number generator for f16 and short on the CPU backend #2587

Merged

9prady9 approved these changes Jul 18, 2019

View reviewed changes

9prady9 merged commit 42d3612 into arrayfire:master

9prady9 deleted the unary branch

July 18, 2019 11:49

Read the original on github.com ↗