shehzan10 · GitHub

@shehzan10

Copy link Copy Markdown

Member

This PR deals with removing CUDA 6.5 support and asserting a minimum CUDA version of 7.0.
It does NOT enable features such as C++11 etc that are associated with using CUDA 7 as minimum version.

Also remove boost inline for older CUDA versions

@9prady9

Copy link Copy Markdown

Member

@shehzan10 Is there any reason you refrained from enabling C++11 support ?

@shehzan10

Copy link Copy Markdown

Member Author

I wanted that to be done when C++11 features start getting used. That is, the boost stuff is replaced by STL.

pavanky

#if CUDA_VERSION < 7000
#error "ArrayFire CUDA requires CUDA Toolkit Version 7.0 or newer."
#endif

Copy link Copy Markdown

Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason you want to have this here instead of cmake?

In CMake it is as simple as requesting a minimum version in FIND_PACKAGE(CUDA, 7.0) or something similar.

Copy link Copy Markdown

Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, we could do that.

Merged

@shehzan10

@pavanky

Copy link Copy Markdown

Member

@shehzan10

Copy link Copy Markdown

Member Author

Let me run the PR builds. Somehow forgot about it.

PS. OSX CUDA Might fail on tests - But thats a system issue.

build arrayfire linux ci
build arrayfire osx cuda ci
build arrayfire windows ci

@shehzan10

Copy link Copy Markdown

Member Author

I think it can be merged now

@umar456

Read the original on github.com ↗