shehzan10 · GitHub

Copy link Copy Markdown

Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you move this into the backend? This type of functionality should not be exposed in the API layer.

Copy link Copy Markdown

Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

getDataDims() is already available as a method to C-API. Whats the need to call it in the backend? It's just going to add redundant code.

Copy link Copy Markdown

Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a logical separation between the api and the backend codes. The api calls should not implement any functionality. It should only expose the backend state to the user.

Copy link Copy Markdown

Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file is located misleadingly. This should have ideally been under src/backend/internal.cpp. All backends use this file internally so this is technically part of the backend code, not the api code.

Read the original on github.com ↗