Contributor
Contributor Author
should I add @9a24f0 to .mailmap or copying.md?
Member
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've made comments to the SMX file only, but they apply to the SMP file in the same way. The graphics seem to convert fine, so there are only structural changes left to do.
Member
should I add @9a24f0 to .mailmap or copying.md?
If you based your changes on their code, then yes, you have to add them to copying.md.
Contributor Author
@heinezen I've restructured the changes, please take a look. passing a variable of type Variant through the base class constructor e.g. super().__init__(......) was causing compilation errors so instead I created a function 'init' which essentially acts as the constructor for the base classes, maybe I was doing something silly though :. Either way, I think the structure is better now.
Member
@jere8184 I've managed to remove the inheritance from the classes used by the fused SMXLayerVariant which makes the whole thing a bit less complicated. Since the change was hard to explain, I just did and pushed it myself. While testing, I also found a small bug that got fixed too.
Member
I'll do a few performance test before I merge. Hopefully we didn't make the code slower accidentally :D
Contributor Author
I'll do a few performance test before I merge. Hopefully we didn't make the code slower accidentally :D
Nice
Member
DE2 media export time on this MR:
INFO [py] -- Exporting graphics files...
INFO [py] Dumping metadata files...
INFO [py] Finished export of modpack 'de2_base' v0.6.0 (75.19 seconds)
INFO [py] Finished export (75.19 seconds)
DE2 media export time on master:
INFO [py] -- Exporting graphics files...
INFO [py] Dumping metadata files...
INFO [py] Finished export of modpack 'de2_base' v0.6.0 (74.66 seconds)
INFO [py] Finished export (74.66 seconds)
It's probably safe to say that the difference is negligeable :P
Member
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added documentation to the classes, so it should be much easier to work on the cython files from now on :)
Closed