Copy link
Copy Markdown
Collaborator
Types of changes
- Add exact line-search for
ot.gromov.gromov_wassersteinandot.gromov.fused_gromov_wassersteinwhenloss_fun = 'kl_loss'which can be called by settingarmijo=False(default for the method). Note that these solvers ignored the providedarmijoparameter with this loss enforcingarmijo=True. - Extend
ot.gromov.solve_gromov_linesearchto any loss with common decomposition. - Adapt the behavior of dependent solvers that also enforced
armijo=True:ot.gromov.gromov_barycentersandot.gromov.fgw_barycenters - Add gradients in this setting for
ot.gromov.gromov_wasserstein2andot.gromov.fused_gromov_wasserstein2
Motivation and context / Related issue
How has this been tested (if it applies)
- Extended existing test for
ot.gromov.gromov_wassersteinandot.gromov.fused_gromov_wassersteinwith kl loss, looping over armijo values.
PR checklist
- I have read the CONTRIBUTING document.
- The documentation is up-to-date with the changes I made (check build artifacts).
- All tests passed, and additional code has been covered with new tests.
- I have added the PR and Issue fix to the RELEASES.md file.
Copy link
Copy Markdown
Codecov Report
Additional details and impacted filesMerging #556 ( e3f35cd ) into master ( 53dde7a ) will not change coverage.
The diff coverage is100.00%.
@@ Coverage Diff @@ ## master #556 +/- ## ======================================= Coverage 96.49% 96.49% ======================================= Files 67 67 Lines 14663 14663 ======================================= Hits 14149 14149 Misses 514 514