atnak · GitHub

atnak commented
Dec 28, 2022
•

edited

Loading

Copy link Copy Markdown

Contributor

This PR contains:

Fixes to HtmlUnitNekoDOMBuilder for better handling of <form></form> to fix issues with <input> ownership
- This fixes https://sourceforge.net/p/htmlunit/bugs/1630/
Refactoring HtmlUnitNekoDOMBuilder.addNodeToRightParent() for readability and extensibility

atnak mentioned this pull request

Closed

3 tasks

Copy link Copy Markdown

Member

@atnak still a draft or can i merge this?

Copy link Copy Markdown

Contributor Author

Oh wait I just resumed this today. I'm making tests atm

atnak marked this pull request as ready for review

January 31, 2023 01:59

Copy link Copy Markdown

Contributor Author

@rbri Thanks for the wait, this PR is ready for review / merge now.

Copy link Copy Markdown

Member

Many thanks - as always.
Have merged this and will have a look during the next days.

Copy link Copy Markdown

Member

MalformedHtmlTest now shows some problem - i'm already working on this.

Copy link Copy Markdown

Member

Hope we catch them all - thanks again.

atnak deleted the form_enclosures branch

February 1, 2023 17:23

Read the original on github.com ↗