atnak · GitHub

@atnak

@atnak atnak commented

Dec 21, 2022

edited

Loading

Copy link Copy Markdown

Contributor

wip PR

Attempting to merge local fixes to upstream because HtmlUnitNekoDOMBuilder is getting painful to merge

Fixes for https://sourceforge.net/p/htmlunit/bugs/1630/

TODO:

  • refactor addNodeToRightParent() a bit
  • add a few more fixes for table handling in addNodeToRightParent()
  • consider how to give tests

@rbri

Copy link Copy Markdown

Member

@atnak i guess i have to wait for more commits here before having a look - right?

regarding the tests i guess you can use something from com.gargoylesoftware.htmlunit.html.parser as template.

@rbri

Copy link Copy Markdown

Member

and also thanks for the contribution

@atnak

atnak deleted the hotfix_nakagawa_form_enclosures branch

December 28, 2022 14:48

@atnak atnak mentioned this pull request

Dec 28, 2022

Merged

@atnak

Copy link Copy Markdown

Contributor Author

Read the original on github.com ↗